Skip to content

Conversation

@FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented May 14, 2021

Fix the issued caused by a recent PR #18031 in azure-cli. In that PR, the sdk version is updated to 11.2.0 in cli and the integration test in extension repo is performed with latest cli from dev branch. As a result, the api version of some operations in the test recordings for some test cases do not match. The most common mismatch is, the api version of the delete operation is changed from 2021-02-01 to 2021-03-01.

The following test cases are affected and need to be modified:

  • test_aks_update_azurekeyvaultsecretsprovider_with_secret_rotation
  • test_aks_nodepool_get_upgrades
  • test_aks_enable_addon_with_azurekeyvaultsecretsprovider
  • test_aks_create_with_windows
  • test_aks_create_with_pod_identity_enabled
  • test_aks_create_with_fips
  • test_aks_create_with_azurekeyvaultsecretsprovider_addon
  • test_aks_create_with_auto_upgrade_channel
  • test_aks_create_with_ahub
  • test_aks_create_using_azurecni_with_pod_identity_enabled
  • test_aks_create_none_private_dns_zone
  • test_aks_create_addon_with_azurekeyvaultsecretsprovider_with_secret_rotation

The two unconfirmed test cases have some problems and need the help of the coder owner to provide new recording files.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@FumingZhang
Copy link
Member Author

@JunSun17 could you please help provide a new recording file for case test_aks_create_with_fips?

@FumingZhang
Copy link
Member Author

@gtxistxgao @norshtein could you please help provide a new recording file for case test_aks_nodepool_get_upgrades?

@haitch haitch mentioned this pull request May 14, 2021
3 tasks
@fengzhou-msft fengzhou-msft merged commit 0e629c1 into Azure:master May 16, 2021
@FumingZhang FumingZhang deleted the fumingzhang/fix-recordings branch May 17, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants